RFR: 8071571: Move substring of same string to slow path

Martin Buchholz martinrb at google.com
Fri Mar 27 22:01:15 UTC 2015


On Fri, Mar 27, 2015 at 2:57 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:

> Hi,
>
> @Martin: does the final have some functional reason to be present?
> I see it just bulks up the source, reducing readability.  If it is useful
> to improve performance then fine.
>

If you use the idiom
final Type foo = this.foo;
and leave out the final,
there is a risk of a maintainer assigning to foo and introducing a bug.
Maybe I should stop, since no one seems to understand it?



More information about the core-libs-dev mailing list