RFR: 7113878: LogManager - namedLoggers should be ConcurrentHashMap instead of Hashtable

Daniel Fuchs daniel.fuchs at oracle.com
Mon Mar 30 09:27:21 UTC 2015


Thanks all for your reviews!

If I don't hear more then
http://cr.openjdk.java.net/~dfuchs/webrev_7113878/webrev.01/

is what I'm going to push.

best regards,

-- daniel

On 28/03/15 00:39, Martin Buchholz wrote:
> Claes,
>
> Right you are - I stand corrected!
>
> On Fri, Mar 27, 2015 at 4:02 PM, Claes Redestad <claes.redestad at oracle.com>
> wrote:
>
>>
>> On 2015-03-27 21:12, Martin Buchholz wrote:
>>
>>> Random advice - the default concurrency level of ConcurrentHashMap is 16,
>>> and that is almost always more than needed, probably also including here.
>>>
>>
>> I believe JSR-166e (JDK8 and onwards) mostly removed the concept of
>> concurrency level from ConcurrentHashMap (while it's still there in some
>> constructors to confuse things). I recall some tests showing that the
>> difference in footprint between CHM and regular HashMap/Hashtable is now
>> negligible even for empty, default-initialized instances.
>>
>> /Claes
>>




More information about the core-libs-dev mailing list