RFR: 8077846: improve locking strategy for readConfiguration(), reset(), and initializeGlobalHandlers()

Mandy Chung mandy.chung at oracle.com
Tue May 5 06:19:31 UTC 2015


On 5/4/2015 11:52 AM, Daniel Fuchs wrote:
> On 04/05/15 16:46, Peter Levart wrote:
>> Hi Daniel,
>>
>> Here it is:
>>
>> http://cr.openjdk.java.net/~plevart/misc/LogManager.synchronization/webrev.04/ 
>>
>
> Looks good for me Peter :-)
> Hopefully Mandy will like it too!
>

Yes it looks good to me.  Thanks to both of you for imprpving the 
synchronization.  This is the comment on the test I sent last round:

TestConfigurationLock.java

    Copyright year should be 2015

TestConfigurationLock.properties

    It would be good to delete all commented lines except the lines
    relevant to the setting to make it obvious what the configuration is.

Mandy




More information about the core-libs-dev mailing list