RFR [9] RandomFactory should be in the jdk.testlibrary package

[Chris Hegarty]

When trying to use the recently added RandomFactory test library utility, I noticed that it is missing a package declaration. The pattern to date has been for these test library utilities to be declared in the jdk.testlibrary package, and imported by tests requiring them. This is a simple patch that does just that.

I think this was a minor oversight, as opposed to a deliberate decision to put RandomFactory in the unnamed package.


diff --git a/test/lib/testlibrary/jdk/testlibrary/RandomFactory.java b/test/lib/testlibrary/jdk/testlibrary/RandomFactory.java
--- a/test/lib/testlibrary/jdk/testlibrary/RandomFactory.java
+++ b/test/lib/testlibrary/jdk/testlibrary/RandomFactory.java
@@ -21,6 +21,8 @@
  * questions.
  */
 
+package jdk.testlibrary;
+
 import java.util.Random;
 import java.util.SplittableRandom;
diff --git a/test/java/lang/Double/ParseHexFloatingPoint.java b/test/java/lang/Double/ParseHexFloatingPoint.java
--- a/test/java/lang/Double/ParseHexFloatingPoint.java
+++ b/test/java/lang/Double/ParseHexFloatingPoint.java
@@ -32,6 +32,8 @@
  * @key randomness
  */
 
+import jdk.testlibrary.RandomFactory;
+
 public class ParseHexFloatingPoint {
     private ParseHexFloatingPoint(){}
 
diff --git a/test/java/lang/Integer/BitTwiddle.java b/test/java/lang/Integer/BitTwiddle.java
--- a/test/java/lang/Integer/BitTwiddle.java
+++ b/test/java/lang/Integer/BitTwiddle.java
@@ -33,6 +33,7 @@
  */
 
 import java.util.Random;
+import jdk.testlibrary.RandomFactory;
 import static java.lang.Integer.*;
 
 public class BitTwiddle {
diff --git a/test/java/lang/Long/BitTwiddle.java b/test/java/lang/Long/BitTwiddle.java
--- a/test/java/lang/Long/BitTwiddle.java
+++ b/test/java/lang/Long/BitTwiddle.java
@@ -33,6 +33,7 @@
  */
 
 import java.util.Random;
+import jdk.testlibrary.RandomFactory;
 import static java.lang.Long.*;
 
 public class BitTwiddle {
diff --git a/test/java/lang/Math/CubeRootTests.java b/test/java/lang/Math/CubeRootTests.java
--- a/test/java/lang/Math/CubeRootTests.java
+++ b/test/java/lang/Math/CubeRootTests.java
@@ -32,6 +32,8 @@
  * @key randomness
  */
 
+import jdk.testlibrary.RandomFactory;
+
 public class CubeRootTests {
     private CubeRootTests(){}
 
diff --git a/test/java/lang/Math/HypotTests.java b/test/java/lang/Math/HypotTests.java
--- a/test/java/lang/Math/HypotTests.java
+++ b/test/java/lang/Math/HypotTests.java
@@ -32,6 +32,8 @@
  * @key randomness
  */
 
+import jdk.testlibrary.RandomFactory;
+
 public class HypotTests {
     private HypotTests(){}
 
diff --git a/test/java/lang/Math/IeeeRecommendedTests.java b/test/java/lang/Math/IeeeRecommendedTests.java
--- a/test/java/lang/Math/IeeeRecommendedTests.java
+++ b/test/java/lang/Math/IeeeRecommendedTests.java
@@ -32,6 +32,8 @@
  * @key randomness
  */
 
+import jdk.testlibrary.RandomFactory;
+
 public class IeeeRecommendedTests {
     private IeeeRecommendedTests(){}
 
diff --git a/test/java/lang/Math/Log1pTests.java b/test/java/lang/Math/Log1pTests.java
--- a/test/java/lang/Math/Log1pTests.java
+++ b/test/java/lang/Math/Log1pTests.java
@@ -32,6 +32,8 @@
  * @key randomness
  */
 
+import jdk.testlibrary.RandomFactory;
+
 public class Log1pTests {
     private Log1pTests(){}
 
diff --git a/test/java/math/BigDecimal/StringConstructor.java b/test/java/math/BigDecimal/StringConstructor.java
--- a/test/java/math/BigDecimal/StringConstructor.java
+++ b/test/java/math/BigDecimal/StringConstructor.java
@@ -33,6 +33,7 @@
 
 import java.math.*;
 import java.util.Random;
+import jdk.testlibrary.RandomFactory;
 
 public class StringConstructor {
 
diff --git a/test/java/math/BigInteger/BigIntegerTest.java b/test/java/math/BigInteger/BigIntegerTest.java
--- a/test/java/math/BigInteger/BigIntegerTest.java
+++ b/test/java/math/BigInteger/BigIntegerTest.java
@@ -40,6 +40,7 @@
 import java.io.ObjectOutputStream;
 import java.math.BigInteger;
 import java.util.Random;
+import jdk.testlibrary.RandomFactory;
 
 /**
  * This is a simple test class created to ensure that the results
diff --git a/test/java/math/BigInteger/ModPow65537.java b/test/java/math/BigInteger/ModPow65537.java
--- a/test/java/math/BigInteger/ModPow65537.java
+++ b/test/java/math/BigInteger/ModPow65537.java
@@ -37,6 +37,7 @@
 import java.security.*;
 import java.security.spec.*;
 import java.util.Random;
+import jdk.testlibrary.RandomFactory;
 
 public class ModPow65537 {
 
diff --git a/test/java/math/BigInteger/PrimeTest.java b/test/java/math/BigInteger/PrimeTest.java
--- a/test/java/math/BigInteger/PrimeTest.java
+++ b/test/java/math/BigInteger/PrimeTest.java
@@ -40,6 +40,7 @@
 import java.util.Set;
 import java.util.SplittableRandom;
 import java.util.TreeSet;
+import jdk.testlibrary.RandomFactory;
 import static java.util.stream.Collectors.toCollection;
 import static java.util.stream.Collectors.toList;
 
diff --git a/test/java/math/BigInteger/SymmetricRangeTests.java b/test/java/math/BigInteger/SymmetricRangeTests.java
--- a/test/java/math/BigInteger/SymmetricRangeTests.java
+++ b/test/java/math/BigInteger/SymmetricRangeTests.java
@@ -40,6 +40,7 @@
 import java.util.Arrays;
 import java.math.BigInteger;
 import java.util.Random;
+import jdk.testlibrary.RandomFactory;
 
 public class SymmetricRangeTests {
 
diff --git a/test/java/util/regex/RegExTest.java b/test/java/util/regex/RegExTest.java
--- a/test/java/util/regex/RegExTest.java
+++ b/test/java/util/regex/RegExTest.java
@@ -46,6 +46,7 @@
 import java.util.*;
 import java.nio.CharBuffer;
 import java.util.function.Predicate;
+import jdk.testlibrary.RandomFactory;
 
 /**
  * This is a test class created to check the operation of


-Chris.