RFR: 8062518: AIOBE occurs when accessing to document function in extended function in JAXP

[huizhe wang]

Hi Aleksej,

The fix looks good.

For the test, it would be better to add an externalDoc:
        static final String externalDoc= "<?xml version=\"1.0\" 
encoding=\"UTF-8\"?><Test>External Doc</Test>"

so that the expectedResult becomes [Test:Doc][Test:External Doc] instead 
of [Test:Doc][Test:Doc] thus verifies the external document is correctly 
read.

Please also move the test to 
jaxp/test/javax/xml/jaxp/unittest/javax/xml/transform, follow the TestNG 
format as other tests in the package, and name it XSLTFunctionsTest. Add 
the xml, xsl, externalDoc and expectedResult in a dataProvider called 
"document". Change the test method to testDocument(with these 
parameters), and Javadoc

/**
  * @bug 8062518
  * Verifies that a reference to the DTM created by XSLT document function is actually read from the DTM by an extension function.
  * @param ...
  */

Move make all data static and move them to the bottom of the class so 
that tests are at the top.

The summary of the test would look something like the following, 
allowing function tests to be added and grouped.

/*
  * @summary This class contains tests for XSLT functions.
  */

Thanks,
Joe

On 5/7/2015 8:33 AM, Aleksej Efimov wrote:
> Hi,
> Please, review the second version of the fix for JDK-8062518 [1]
> The previously proposed fix for the reported bug was slightly 
> incorrect - it solves the problem by providing the access to the node 
> from other DTM and it was not a good/proper solution.
> New fix [2] properly prepares a nodeList using a node's dtm, not the 
> main one.
> Testing: JCK, JTREG with new test and JAXP testset shows no failures
>
> Thank you,
> Aleksej
>
> [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8062518
> [2] Webrev: http://cr.openjdk.java.net/~aefimov/8062518/9/webrev.01
>
>
> On 01/19/2015 03:26 PM, Aleksej Efimov wrote:
>> Please, review the fix for the failure observed while accessing 
>> external document during xsl transformation: 
>> https://bugs.openjdk.java.net/browse/JDK-8062518
>> The jaxp code limits the access to external documents, but there is a 
>> possibility to access such documents from the xsl code - new 
>> regression test checks this functionality. The fix removes this 
>> restriction and AIOBE: 
>> http://cr.openjdk.java.net/~aefimov/8062518/9/webrev.00/
>>
>> Testing:
>> xml related regression tests (with new test) - no failures (from jdk 
>> and jaxp repos).
>> JCK xml related tests - no failures.
>>
>> With Best Regards,
>> Aleksej
>