Review request for JDK-8078596: jaxp tests failed in modular jdk due to internal class access

[Lance Andersen]

Hi Frank,  

Seems OK

Best
Lance
On May 15, 2015, at 5:48 AM, Frank Yuan <frank.yuan at oracle.com> wrote:

> Hi, Joe and All
> 
> 
> 
> This is a test bug on 9-repo-jigsaw, jaxp tests failed due to internal class
> access.
> 
> 
> 
> To fix this bug, I made the following changes:
> 
> 1. moved the tests which test internal APIs to separate directory and added
> @modules for them
> 
> 2. for other tests which don't intend to test internal APIs but have some
> internal API dependencies:
> 
>  2.1. replaced internal APIs usage with public APIs
> 
>  2.2. replaced the constants defined in internal classes with local
> constants
> 
> 
> 
> As Alan's suggestion, I would push the changes to jdk9/dev and ask an open
> review. Would you like to take a look?  Any comment will be appreciated.
> 
> 
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8078596
> 
> webrev: http://cr.openjdk.java.net/~fyuan/8078596/webrev.00/
> 
> 
> 
> 
> 
> 
> 
> Thanks,
> 
> 
> 
> Frank
> 
> 
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com