RFR (XXS) 8080535: (ch) Expected size of Character.UnicodeBlock.map is not optimal

Martin Buchholz martinrb at google.com
Fri May 15 23:18:30 UTC 2015


I don't think you're taking the load factor into account.
https://code.google.com/p/guava-libraries/source/browse/guava/src/com/google/common/collect/Maps.java?r=f8144b4df7eec5f1c9e6942d8d5ef734a8767fd9#110
You want to check (via reflection) that the size of the backing array is
unchanged if you copy the map with new HashMap(map).

I wouldn't bother defining the constant.

On Fri, May 15, 2015 at 4:01 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com>
wrote:

> Hello!
>
> When constructing the map, the expected size is specified to be 256, but
> then 510 elements are inserted.
> A new whitebox test is provided, so the next time the number of entries
> grows, the expected size will not be forgotten.
>
> Would you please help review this fix?
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8080535
> WEBREV: http://cr.openjdk.java.net/~igerasim/8080535/00/webrev/
>
> Sincerely yours,
> Ivan
>



More information about the core-libs-dev mailing list