RFR [9] 8080422: some docs cleanup for core libs
alexander stepanov
alexander.v.stepanov at oracle.com
Mon May 18 16:02:32 UTC 2015
Hello, Lance, Roger,
Thanks!
P.S. sorry - one minor change after the review - a list was added in
ExtensionDependency.java:
http://cr.openjdk.java.net/~avstepan/8080422/webrev.02/src/java.base/share/classes/sun/misc/ExtensionDependency.java.udiff.html
(please update the page).
Regards,
Alexander
On 18.05.2015 18:54, Lance Andersen wrote:
> The revised changes seem OK in addition to the previous webrev
>
> Best
> Lance
> On May 18, 2015, at 11:36 AM, alexander stepanov
> <alexander.v.stepanov at oracle.com
> <mailto:alexander.v.stepanov at oracle.com>> wrote:
>
>> Hello Roger,
>>
>> Fixed; please see
>> http://cr.openjdk.java.net/~avstepan/8080422/webrev.02/index.html
>> <http://cr.openjdk.java.net/%7Eavstepan/8080422/webrev.02/index.html>
>>
>> Regards,
>> Alexander
>>
>> On 18.05.2015 17:43, Roger Riggs wrote:
>>> Hi Alexander,
>>>
>>> Thanks for these needed cleanups; a few corrections below.
>>>
>>>
>>>
>>> 1) src/java.base/share/classes/jdk/internal/util/xml/impl/Parser.java:
>>>
>>> "The grammar *which *this method can read is" can remove the 'which'
>>>
>>>
>>>
>>> 2) src/java.base/share/classes/sun/misc/CharacterEncoder.java: 107
>>>
>>> The {@code <newline>} is confusing, typically @code marks a literal
>>> but in this case it is a symbol for the new line character.
>>> Perhaps use only "newline" without any special chars, as is used in
>>> PrintStream.
>>>
>>> src/java.base/share/classes/sun/misc/ExtensionDependency.java: 106
>>> Correct the spelling of attriutes:
>>> - * @param jarFile containing the *attriutes *declaring the
>>> dependencies
>>> + * @param jar containing the *attributes *declaring the
>>> dependencies
>>>
>>>
>>> 3) src/java.base/share/classes/sun/misc/resources/Messages_de.java: 26
>>> Please use {@code instead of <code>...
>>> - * <p> This class represents the <code>ResourceBundle</code>
>>> + * This class represents the <code>ResourceBundle</code>
>>>
>>> 4) Ditto all of the files in:
>>> src/java.base/share/classes/sun/misc/resources/Messages_* files:
>>>
>>> Thanks, Roger
>>>
>>>
>>>
>>> On 5/18/2015 10:08 AM, alexander stepanov wrote:
>>>> Please see the updated webrev
>>>> http://cr.openjdk.java.net/~avstepan/8080422/webrev.01/
>>>> - some misprints were fixed as well
>>>> (not 100% sure if "comparision" should be replaced with
>>>> "comparison", but the latter looks more suitable).
>>>>
>>>> Thanks,
>>>> Alexander
>>>>
>>>> On 15.05.2015 20:16, alexander stepanov wrote:
>>>>> Hello,
>>>>>
>>>>> Could you please review the following fix
>>>>> http://cr.openjdk.java.net/~avstepan/8080422/webrev.00/
>>>>> for
>>>>> https://bugs.openjdk.java.net/browse/JDK-8080422
>>>>>
>>>>> Just some HTML markup fix.
>>>>>
>>>>> The affected packages should (probably) not be visible in the new
>>>>> modular system, but nevertheless...
>>>>>
>>>>> Thanks,
>>>>> Alexander
>>>>>
>>>>
>>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>
More information about the core-libs-dev
mailing list