Patch to improve primitives Array.sort()
Paul Sandoz
paul.sandoz at oracle.com
Tue May 26 09:54:57 UTC 2015
Here is an updated webrev:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8080945-nearly-sorted-primitives/webrev/
I took the liberty of:
- in DualPivotQuicksort sprinkling some more comments; and
- moving and renaming the test. Code was also reformatted to better fit the JDK style. I reduced the size array, otherwise it uses a lot of memory and to further reduce memory the runTests method does not create all arrays upfront.
Kristen, unfortunately the ' character in your name and email addresses causes some issues with the jcheck tool, which only supports a subset of valid characters [1], so for now i have removed that character from the your name and email address, sorry about that, it's not personal :-) I hope we can get that tool and infrastructure updated before we push.
Paul.
[1] http://hg.openjdk.java.net/code-tools/jcheck/file/196ab0ad64ad/jcheck.py#l156
On May 22, 2015, at 4:23 PM, Paul Sandoz <Paul.Sandoz at oracle.com> wrote:
> On May 22, 2015, at 3:55 PM, "Rezaei, Mohammad A." <Mohammad.Rezaei at gs.com> wrote:
>> We have a set of JMH tests.
>
> Great.
>
> I created a bug for this issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8080945
>
>
>> We'll work with Sunny to make those part of the webrev (where do they go?) and the specific test you suggested below.
>>
>
> Not actually sure, for now let's keep 'em with the unit test.
>
> I seem to recall a there was a "space" being arranged for benchmarks but i have forgotten if any progress has been made on that.
>
> Paul.
More information about the core-libs-dev
mailing list