RFR [9] 8080502: Changing accessing module resources

Alan Bateman Alan.Bateman at oracle.com
Fri May 29 13:02:15 UTC 2015



On 26/05/2015 13:24, Miroslav Kos wrote:
> Thanks, you are correct. Changed to try-catch with resources, the some 
> code moved to SchemaCache. Refernced resources found by 
> com.sun.tools.internal.xjc.SchemaCache.ResourceResolver added to 
> collection and closed after parsing.
>
> updated webrev: http://cr.openjdk.java.net/~mkos/8080502/jaxws.02/
> tests: rerun standalone tests for bot standalone build and for JDK.
This looks much better, it seems to close all the streams now.

There's a TODO-Miran left in MetroConfigLoader that I assume should be 
looked at before you push.

In ParserContext then you could throw InternalError(e) rather than 
e.getMessage(), assuming of course this doesn't need to compile on JDK 7 
or older.

-Alan



More information about the core-libs-dev mailing list