RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

[Michael Haupt]

Hi Claes, Peter, Vladimir, all,

I really support Peter's latest proposal: it reduces the amounts of code, synchronisation, and complication, and actually addresses the problem at hand too. What's more to wish for? :-)

I propose to adopt this solution: http://cr.openjdk.java.net/~plevart/jdk9-dev/BMH.race/webrev.03/

Not sure how to proceed. Peter's name should be on the changeset. As he's a Committer, I'm fine if he pushes it once it's signed off by a Reviewer.

Thanks,

Michael

> Am 05.11.2015 um 12:07 schrieb Claes Redestad <claes.redestad at oracle.com>:
> 
> 
> On 2015-11-05 08:00, Peter Levart wrote:
>> 
>> 
>> Ok, here it is:
>> 
>> http://cr.openjdk.java.net/~plevart/jdk9-dev/BMH.race/webrev.03/
>> 
>> I just moved CACHE registration into SpeciesData.initForBootstrap() method, so no new method is needed. Note that patched source now contains the same number of lines as original. How does the jigsaw HelloWorld score now?
>> 
>> Regards, Peter
> 
> Thanks, this looks really good to me. I verified that #classes are the same and it even looks like footprint improves ever so slightly.
> 
> /Claes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment