RFR 8136496 Connection.begin/endRequest
Lance Andersen
lance.andersen at oracle.com
Thu Nov 5 15:11:27 UTC 2015
Hi Roger,
thank you. I made the proposed changes below.
Yes I will do a format clean-up separately as there are issues in multiple places
Best
Lance
On Nov 5, 2015, at 10:00 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> Hi Lance,
>
> Looks fine except for a few editorial fixes.
>
> Editorial:
>
> - Update copyrights to 2015.
>
> src/java.sql/share/classes/java/sql/Connection.java:
> - about 1515: "." on a separate line.
> - several places: missing "." after "no-op"
> - later: missing "." after "{@code beginRequest} is a no-op"
>
> src/java.sql/share/classes/javax/sql/PooledConnection.java
> - about line 75: the <UL> should be lower case to match </ul>
> - you could fix the <P> -> <p> in the line before the edit.
> [ There other editorial inconsistencies and indenting in the file; but maybe that's a different review.]
>
> Roger
>
>
> On 11/2/2015 12:37 PM, Lance Andersen wrote:
>> Hi,
>>
>> Need a reviewer for 8136496. The CCC has been approved.
>>
>> The webrev can be found at http://cr.openjdk.java.net/~lancea/8136496/webrev.00/
>>
>> Best
>> Lance
>>
>>
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com
>>
>>
>>
>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
More information about the core-libs-dev
mailing list