[RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Lance @ Oracle lance.andersen at oracle.com
Thu Nov 12 13:01:00 UTC 2015


Hi,

Overall it looks ok,

I would however suggest adding a couple of tests to the jdk that run with/out a security manager as a sanity check.

Best
Lance 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
Sent from my iPad

> On Nov 12, 2015, at 3:55 AM, Miroslav Kos <miroslav.kos at oracle.com> wrote:
> 
> .. anyone?
> 
>> On 10/11/15 15:31, Miroslav Kos wrote:
>> Ping ... Would somebody find time for this one?
>> 
>> Thanks
>> M.
>> 
>> 
>>> On 26/10/15 13:59, Miroslav Kos wrote:
>>> Hi everybody,
>>> 
>>> I'd like to ask you for a review for
>>> 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader
>>> 
>>> It is about changes in pluggability layer - there was a proprietary service loading implementation which was not fully compatible with to use java.util.ServiceLoader facility. There are similar changes in all JAX-* APIs specs - JAX-B,  JAX-WS and SAAJ.
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8131334
>>> webrev: http://cr.openjdk.java.net/~mkos/8131334/jaxws.01/
>>> specdiff: http://cr.openjdk.java.net/~mkos/8131334/specdiff.09/
>>> 
>>> Testing - there are tests in standalone project to ensure there that the old behavior is still supported.
>>> 
>>> Thanks
>>> Miran
>>> 
>> 
> 



More information about the core-libs-dev mailing list