RFR: 8029574: TreeMap: optimization of method computeRedLevel()

Martin Buchholz martinrb at google.com
Mon Nov 16 20:16:06 UTC 2015


I renamed sz to size and added

+     *
+     * @param size the (non-negative) number of keys in the tree to be
built


On Mon, Nov 16, 2015 at 12:01 PM, Aleksey Shipilev <
aleksey.shipilev at oracle.com> wrote:

> On 11/16/2015 10:46 PM, Martin Buchholz wrote:
> > https://bugs.openjdk.java.net/browse/JDK-8029574
> >
> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/TreeMap-optimization/
>
> +1, cute.
>
> Need to mention this only works for non-negative "sz"? It's hard to
> define what is the result for negative "sz", but I think it is a good
> style to comment the conditions in bit-twiddling methods.
>
> Thanks,
> -Aleksey
>
>
>



More information about the core-libs-dev mailing list