Code Review for JEP 259: Stack-Walking API

David M. Lloyd david.lloyd at redhat.com
Tue Nov 17 00:34:55 UTC 2015


On 11/16/2015 06:13 PM, Mandy Chung wrote:
> I’d like to get the code review done by this week.
>
> I renamed the static factory method from create to getInstance since “create” implies to create a new instance but the method returns a cached instance instead.  I also changed the spec of getCallerClass per [1].  There is not much change since webrev.01.
>
> Webrev:
>     http://cr.openjdk.java.net/~mchung/jdk9/jep259/webrev.02
>
> javadoc:
>     http://cr.openjdk.java.net/~mchung/jdk9/jep259/api/
>
> Mandy
> [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-November/036589.html

I'll give the API a (very unofficial) "looks great".

-- 
- DML



More information about the core-libs-dev mailing list