RFR: jsr166 jdk9 integration wave 2

Aleksey Shipilev aleksey.shipilev at oracle.com
Tue Nov 17 13:07:04 UTC 2015


On 11/17/2015 02:04 AM, Martin Buchholz wrote:
> On Mon, Nov 16, 2015 at 2:42 PM, Aleksey Shipilev
> <aleksey.shipilev at oracle.com <mailto:aleksey.shipilev at oracle.com>> wrote:
>     ForkJoinWorkerThread.newThread/:
>      * I think this one requires CCC, because it changes public API in
>     newThread.
> 
> 
> That's where someone from Oracle needs to help out ...

Yes, that's a trivial API correction, as Doug notes.
Paul had already submitted CCC, and it is fast-tracking now.

>     PhaserBasic/:
>      * Are those tracing statements ("// trace("barrier action",
>     startTime);") kept for a reason? Should we conditionalize them with
>     "static final boolean"-s?
> 
> Phaser/Basic has been troublesome, and it still has unresolved rare 
> failures... Those traces were obviously added for debugging, but I'm
> still reluctant to remove them...

Yes. My point is that it may be better to conditionalize the debug
printing on static final boolean field, rather than having a
non-compiled commented line.

Thanks,
-Aleksey





More information about the core-libs-dev mailing list