[RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

[Daniel Fuchs]

On 19/11/15 18:31, Miroslav Kos wrote:
> Hi Lance,
>
> I added jtreg test(s) -
> http://cr.openjdk.java.net/~mkos/8131334/jdk.01/index.html
> There are several scenarios being tested, all without/with SM.
>
> The test preparation I am doing in java (based on test args), so the
> test creates/deletes $JAVA_HOME/conf/jaxm.properties.

Hi Miran,

I would expect this to fail horribly - you may not have the
right to create anything under $JAVA_HOME/conf - it may even
be a read-only file system... And I would be very uneasy as this
may have side effects on tests executing later on if anything
is left over in the java home conf dir...

best regards,

-- daniel


>
> Hopefully it's correct approach.
>
> Thanks
> Miran
>
>
>
> On 12/11/15 15:07, Lance Andersen wrote:
>> Not sure exactly what you want to set, but you can set system
>> properties or run tests from a script or from testNG
>>
>> For running a script, see http://openjdk.java.net/jtreg/vmoptions.html
>>
>> Best
>> Lance
>> On Nov 12, 2015, at 8:28 AM, Miroslav Kos <miroslav.kos at oracle.com
>> <mailto:miroslav.kos at oracle.com>> wrote:
>>
>>> I have a set of tests in standalone project (using bash scripts), but
>>> the problem is that to test the correct behavior, configuring of jdk
>>> is necessary (property file) - have no idea if something like this is
>>> possible with jtreg - are there any similat tests already?
>>>
>>> Thanks
>>> Miran
>>>
>>> On 12/11/15 14:01, Lance @ Oracle wrote:
>>>> Hi,
>>>>
>>>> Overall it looks ok,
>>>>
>>>> I would however suggest adding a couple of tests to the jdk that run
>>>> with/out a security manager as a sanity check.
>>>>
>>>> Best
>>>> Lance
>>>>
>>>>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
>>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> <tel:+1.781.442.2037>
>>>> Oracle Java Engineering
>>>> 1 Network Drive <x-apple-data-detectors://34/0>
>>>> Burlington, MA 01803 <x-apple-data-detectors://34/0>
>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>> Sent from my iPad
>>>>
>>>> On Nov 12, 2015, at 3:55 AM, Miroslav Kos <miroslav.kos at oracle.com>
>>>> wrote:
>>>>
>>>>> .. anyone?
>>>>>
>>>>> On 10/11/15 15:31, Miroslav Kos wrote:
>>>>>> Ping ... Would somebody find time for this one?
>>>>>>
>>>>>> Thanks
>>>>>> M.
>>>>>>
>>>>>>
>>>>>> On 26/10/15 13:59, Miroslav Kos wrote:
>>>>>>> Hi everybody,
>>>>>>>
>>>>>>> I'd like to ask you for a review for
>>>>>>> 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader
>>>>>>>
>>>>>>> It is about changes in pluggability layer - there was a
>>>>>>> proprietary service loading implementation which was not fully
>>>>>>> compatible with to use java.util.ServiceLoader facility. There
>>>>>>> are similar changes in all JAX-* APIs specs - JAX-B,  JAX-WS and
>>>>>>> SAAJ.
>>>>>>>
>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8131334
>>>>>>> webrev: http://cr.openjdk.java.net/~mkos/8131334/jaxws.01/
>>>>>>> specdiff: http://cr.openjdk.java.net/~mkos/8131334/specdiff.09/
>>>>>>>
>>>>>>> Testing - there are tests in standalone project to ensure there
>>>>>>> that the old behavior is still supported.
>>>>>>>
>>>>>>> Thanks
>>>>>>> Miran
>>>>>>>
>>>>>>
>>>>>
>>>
>>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>
>>
>>
>