[RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

[Lance Andersen]

Hi Miran,  


On Nov 20, 2015, at 10:29 AM, Miroslav Kos <miroslav.kos at oracle.com> wrote:

> On 20/11/15 15:25, Daniel Fuchs wrote:
>> On 20/11/15 09:43, Miroslav Kos wrote:
>>> Locally, it worked for me, but I understand that it's dengerous - global
>>> state is evil ... I removed all the scenarios modifying JDK/conf/ dir -
>>> I just commented out those parts so if necessary, it can be uncommented
>>> and run locally.
>>> http://cr.openjdk.java.net/~mkos/8131334/jdk.02/
>> 
>> Hi Miran,
>> 
>> It's good that you were able to test the jaxm.properties file
>> scenario locally.
>> Commenting it out of the jtreg test so that it's not run
>> automatically in random test env seems like the right thing
>> to do.
>> 
>> best regards,
>> 
>> -- daniel
> Thanks! Lance, are you ok with that?
Given you do not have a way to set the jaxm properties any other way that is fine.  You could if you wanted create your own policy and set it without using a policy file which is what we do in the JDBC and JAXP testNG tests.

That can be done later
> May I push it together with jaxws patch?
Sure thing
> 
> Thanks
> Miran
> 
>> 
>> 
>>> 
>>> Thanks
>>> Miran
>>> 
>>> 
>>> On 19/11/15 21:45, Alan Bateman wrote:
>>>> 
>>>> 
>>>> On 19/11/2015 18:36, Daniel Fuchs wrote:
>>>>> 
>>>>> Hi Miran,
>>>>> 
>>>>> I would expect this to fail horribly - you may not have the
>>>>> right to create anything under $JAVA_HOME/conf - it may even
>>>>> be a read-only file system... And I would be very uneasy as this
>>>>> may have side effects on tests executing later on if anything
>>>>> is left over in the java home conf dir...
>>>>> 
>>>> There may be tests executing concurrently in other agent VMs too so we
>>>> need to avoid changing the config like this.
>>>> 
>>>> -Alan
>>> 
>> 
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com