RFR (S) 8136500: Integer/Long getChars and stringSize should be more idiomatic

Aleksey Shipilev aleksey.shipilev at oracle.com
Tue Nov 24 14:17:56 UTC 2015


On 11/24/2015 02:07 PM, Aleksey Shipilev wrote:
> On 11/24/2015 03:35 AM, John Rose wrote:
>> On Nov 23, 2015, at 1:42 PM, Aleksey Shipilev
>> <aleksey.shipilev at oracle.com <mailto:aleksey.shipilev at oracle.com>> wrote:
>>>
>>> Okay, here it is (only tests changed):
>>> http://cr.openjdk.java.net/~shade/8136500/webrev.06/
>>> <http://cr.openjdk.java.net/%7Eshade/8136500/webrev.06/>
>>
>> Thanks; that's a solid test.
>>
>> Cleanups are good too.
>>
>> You can count me as a reviewer.
> 
> Thanks for reviews, Ivan, John, Sherman and Paul!
> 
> I am pushing this change now.

Oh no, I don't. Pre-integration JPRT runs exposed an opaque dependency
on Integer.sizeTable field from C2 OptimizeStringConcat. I added the
field declaration back:
 http://cr.openjdk.java.net/~shade/8136500/webrev.07/

Cleaning up the compiler code would require much more time, so I would
like to push this JDK part now, and deal with Hotspot compiler later:
  https://bugs.openjdk.java.net/browse/JDK-8143900

Objections?

Thanks,
-Aleksey




More information about the core-libs-dev mailing list