RFR (S) 8136500: Integer/Long getChars and stringSize should be more idiomatic

Aleksey Shipilev aleksey.shipilev at oracle.com
Tue Nov 24 22:44:37 UTC 2015


On 11/24/2015 07:50 PM, Ulf wrote:
> Am 24.11.2015 um 12:07 schrieb Aleksey Shipilev:
>> Thanks for reviews, Ivan, John, Sherman and Paul!
>>
>> I am pushing this change now.
> 
> I know, I'm late, but have you ever tried? :

No, but you can try it yourself. OpenJDK workspace has tests covering
that codepath. Pick up the benchmarks from here:
  http://cr.openjdk.java.net/~shade/8136500/

Note that you need to show a compelling performance improvement to
justify low-level oddities in the code. The reasoning behind this change
was to cleanup the code, while also getting the performance benefits, it
would be sad to go the uglifying route again.

Thanks,
-Aleksey




More information about the core-libs-dev mailing list