Code (Pre-)Review for JEP 280: Indify String Concat
Andrej Golovnin
andrej.golovnin at gmail.com
Thu Nov 26 08:42:21 UTC 2015
Hi Aleksey,
> http://cr.openjdk.java.net/~shade/8085796/webrev.jdk.02/
src/java.base/share/classes/java/lang/Integer.java
src/java.base/share/classes/java/lang/Long.java
I miss JavaDocs for the returned value of the methods #getChars(int,
int, byte[]) and #getCharsUTF16(int, int, byte[]). And it would be
nice to have JavaDocs for the parameters too.
src/java.base/share/classes/java/lang/StringConcatHelper.java
src/java.base/share/classes/java/lang/invoke/StringConcatException.java
test/java/lang/String/concat/ImplicitStringConcatShapesTestGen.java
test/java/lang/String/concat/update-tests.sh
The files do not have a copyright header.
Best regards,
Andrej Golovnin
More information about the core-libs-dev
mailing list