Code (Pre-)Review for JEP 280: Indify String Concat
Aleksey Shipilev
aleksey.shipilev at oracle.com
Fri Nov 27 17:34:55 UTC 2015
Hi Maurizio,
Updated webrevs:
http://cr.openjdk.java.net/~shade/8085796/webrev.langtools.03/
http://cr.openjdk.java.net/~shade/8085796/webrev.jdk.04/
On 11/27/2015 04:03 AM, Maurizio Cimadamore wrote:
> Thanks! The patch looks better, and having the code all in one place
> definitively helps. I think there is still something that you can do to
> improve the code - i.e. all strategies seem to do:
...
> Then, all you have to do is to create the right helper given the command
> line options, and that object will have an API that can be used by Gen
> to perform string concact effectively, w/o switching and minimizing
> duplication.
>
> What do you think?
I agree, these does look better, see the updated webrev.
Thanks,
-Aleksey
More information about the core-libs-dev
mailing list