RFR: 8140344: add support for 3 digit update release numbers
Seán Coffey
sean.coffey at oracle.com
Fri Nov 27 18:36:01 UTC 2015
Looks fine to me Rob. Assuming JPRT job builds & tests ok.
Regards,
Sean.
On 24/11/15 12:40, Rob McKenna wrote:
> You would think, but this fix isn't in jdk_util.c in 6. The test isn't
> in 6 either though.
>
> -Rob
>
> On 24/11/15 04:39, David Holmes wrote:
>> On 24/11/2015 12:24 AM, Rob McKenna wrote:
>>> Thanks David, I'll mark this 9-na. (bcc'ing verona-dev)
>>>
>>> Something similar was fixed in 7
>>> (https://bugs.openjdk.java.net/browse/JDK-8009634) - that may be what
>>> you're thinking of.
>>
>> 6 hit this with 6u101 first, so presumably it was addressed there (and
>> there was a big bug tail for that).
>>
>>> Aside from that are you ok with the changes?
>>
>> Sorry I didn't actually review the code.
>>
>> David
>>
>>> -Rob
>>>
>>> On 18/11/15 09:00, David Holmes wrote:
>>>> On 18/11/2015 1:30 AM, Rob McKenna wrote:
>>>>> I'd expect this to be superseded by 223 completely but I've cc'd
>>>>> verona-dev in case there are objections. At this point the fix is
>>>>> more
>>>>> for the benefit of 7 & 8. I'd be happy to mark this 9-na if that
>>>>> makes
>>>>> more sense?
>>>>
>>>> I'd vote for a 7 (and 8?) specific fix. Didn't this already get fixed
>>>> in 6.
>>>>
>>>> David
>>>>
>>>>> -Rob
>>>>>
>>>>> On 17/11/15 15:19, Alan Bateman wrote:
>>>>>>
>>>>>>
>>>>>> On 17/11/2015 14:47, Rob McKenna wrote:
>>>>>>> Hi folks,
>>>>>>>
>>>>>>> With 7u hitting 101 shortly we've noticed that our Version parsing
>>>>>>> infrastructure balks at the extra digit. With that in mind I'd
>>>>>>> like to
>>>>>>> update the logic surrounding the parsing of version numbers and the
>>>>>>> test itself to use regex instead of the less flexible
>>>>>>> CharacterSequence method.
>>>>>>>
>>>>>>> http://cr.openjdk.java.net/~robm/8140344/webrev.01/
>>>>>> Would it be better to bring this to verona-dev so that this can be
>>>>>> looked at in the context of the JEP 223 changes?
>>>>>>
>>>>>> -Alan
More information about the core-libs-dev
mailing list