RFR:8143413:add toEpochSecond methods for efficient access

Stephen Colebourne scolebourne at joda.org
Mon Nov 30 14:36:55 UTC 2015


The method Javadoc (specs) for each of the three new methods needs to
be enhanced.

For the date ones it needs to say
"The resulting date will have a time component of midnight at the
start of the day."

For the time ones it needs to say
"The resulting time will be on 1970-01-01."

Some of the line wrapping in the tests looks like it is not indented correctly.

Otherwise looks fine,
thanks
Stephen


On 30 November 2015 at 11:50, nadeesh tv <nadeesh.tv at oracle.com> wrote:
> Hi all,
>
> Please review a fix for
>
> Bug Id -https://bugs.openjdk.java.net/browse/JDK-8143413
>
> Issue - add toEpochSecond methods for efficient access
>
> webrev - http://cr.openjdk.java.net/~ntv/8143413/webrev.01/
>
> -- Thanks and Regards,
> Nadeesh TV



More information about the core-libs-dev mailing list