[9] Review request JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

[Miroslav Kos]

On 30/09/15 17:31, Miroslav Kos wrote:
> On 30/09/15 16:50, Georgiy Rakov wrote:
>> 2. This is not related to ServiceLoader feature, but anyway - 
>> SAAJMetaFactory.java:
>>
>>        30 * SAAJ API./_*All *_//_*of the {@code newInstance} methods defined on factories*_/  in
>>        31 * SAAJ 1.3 defer to instances of this class to do the actual object creation.
>>
>> Namely it says that /_*all*_/**the newInstance methods defined on 
>> factories delegate factory creation to SAAJMetaFactory instances, but 
>> this seems to be not exactly true because SOAPConnectionFactory is 
>> not created by SAAJMetaFactory instance.
> Yes, good catch. To fix it, it would be good to add a new abstract method
> public abstract SOAPConnectionFactory newSOAPConnectionFactory()
>     throws SOAPException, UnsupportedOperationException
>
> Would you agree, Deva, Chen? There is a problem with backwards 
> compatibility here ... More defensive would be to name the two 
> factories instead of saying "all"?
Any opinion on this, anybody?

Thanks
Miran


>
> Thanks
> Miran
>
> Btw. I sent this RFR initially to wrong mailing lists, would you check 
> when answering that it's to  Core-Libs-Dev 
> <core-libs-dev at openjdk.java.net> ?
>
>>
>> Thank you,
>> Georgiy.
>>
>