[9] RFR(XS): 8137173: @HotSpotIntrinsicCandidate is not Oracle-specific

[Zoltán Majó]

Hi Alan,
Hi Mark,


On 10/01/2015 05:54 PM, mark.reinhold at oracle.com wrote:
> 2015/10/1 8:41 -0700, alan.bateman at oracle.com:
>> On 01/10/2015 16:31, Zoltán Majó wrote:
>>> please review the patch for JDK-8137173.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8137173
>>>
>>> ...
>>>
>>> Webrev: http://cr.openjdk.java.net/~zmajo/8137173/webrev.00/
>>>
>> This looks okay. Is it time to discuss moving the annotation to
>> another package too?

thank you for the review!

> Yes.  We don't want to create another sun.misc-like dumping ground
> with jdk.internal.  We should prefer small, descriptive subpackages
> for things like this so that, when they are (inevitably) exposed via
> -XaddExports, their exposure can be limited.
>
> I suggest putting this into jdk.internal.vm.annotation, which is
> also a good place for the ReservedStackAccess annotation envisioned
> in JEP 270 (http://openjdk.java.net/jeps/270).

I filed an RFE, JDK-8138732: "move @HotSpotIntrinsicCandidate to the 
jdk.internal.vm.annotation package" [1], to track the issue of moving 
the annotation to a different package. I hope I can take care of it soon.

Thank you and best regards,


Zoltan

[1] https://bugs.openjdk.java.net/browse/JDK-8138732

>
> - Mark