RFR (JAXP) 8138721 : ElementTraversal: javadoc warning; also, hasFeature shall return true

[huizhe wang]

Thanks Daniel, Lance!

On 10/2/2015 7:06 AM, Lance Andersen wrote:
>
> On Oct 2, 2015, at 8:35 AM, Daniel Fuchs <daniel.fuchs at oracle.com 
> <mailto:daniel.fuchs at oracle.com>> wrote:
>
>> Looks fine to me Joe.
>> Strange that a trailing '.' could produce such a warning.
> Perhaps a javadoc bug?

Seems to be, the message didn't make any sense. But it was reported 
before: https://bugs.openjdk.java.net/browse/JDK-4907024 -- although it 
was not because of the <cite> tag as reported. It's just that the 
message didn't reflect the true issue.
>>
>> I have a question however about:
>>
>> (feature.equalsIgnoreCase("ElementTraversal")
>> 128                         && (anyVersion
>> 129                             || version.equals("1.0"))
>>
>> Does this means that ElementTraversal is only supported
>> on DOM 1.0 - and not on DOM 2.0 and 3.0?
>
> I am a little confused on this also as I looked at 
> http://www.w3.org/TR/ElementTraversal/ and seems that it should be OK 
> with DOM 2.0 and 3.0 unless I misunderstood the doc

Element Traversal is a separate specification from core DOM 2.0 and 3.0. 
In the above statement, it reports that the ElementTraversal is 
supported without specifying a version or ElementTraversal Version 1.0. 
That was why I re-formatted it to make sure (feature.equals...) were 
lined up (refer to the Sdiff).

>
> hasFeature() probably should check if feature is null to avoid an NPE?

Added, refer to DOMImplementationImpl. The spec for hasFeature didn't 
declare any exception, so I'm going to just let it return false.

http://cr.openjdk.java.net/~joehw/jdk9/8138721/webrev/

-Joe

>
> Best
> Lance
>>
>> best regards,
>>
>> -- daniel
>>
>>
>> On 02/10/15 02:16, huizhe wang wrote:
>>> Hi,
>>>
>>> Thanks Lance and Daniel for pointing out the javadoc warning! Here's the
>>> fix.  Also, added ElementTraversal to the DOMImplementation supported
>>> feature list.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8138721
>>> http://cr.openjdk.java.net/~joehw/jdk9/8138721/webrev/ 
>>> <http://cr.openjdk.java.net/%7Ejoehw/jdk9/8138721/webrev/>
>>>
>>> Thanks,
>>> Joe
>>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>