RFR: 6823565: Excessive use of HandleList class in de-serialization code causes OutOfMemory

Claes Redestad claes.redestad at oracle.com
Tue Oct 27 13:51:53 UTC 2015



On 2015-10-27 14:21, Aleksey Shipilev wrote:
> On 10/25/2015 04:27 AM, Claes Redestad wrote:
>> when deserializing objects with references to themselves,
>> ObjectInputStream pointlessly marks the object as a dependency of
>> itself, which increases memory required to deserialize certain memory
>> graphs.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-6823565
>> webrev: http://cr.openjdk.java.net/~redestad/6823565/webrev.01/
> Looks fine. A comment in markDependency should probably be updated to
> explain that self-referenced objects are skipped.

Thanks for reviewing, Aleksey!

How about "Additionally, no action is taken if the dependent and target 
are the same."?

http://cr.openjdk.java.net/~redestad/6823565/webrev.02/

/Claes

>
> Thanks,
> -Aleksey
>




More information about the core-libs-dev mailing list