RFR 8080402: File Leak in jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java

Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Sep 7 09:40:49 UTC 2015


Hi!

The close() function isn't really restartable.

So, I think, it's more correct to replace
     RESTARTABLE(close(s), res);
with
     res = close(s);

Sincerely yours,
Ivan

On 07.09.2015 12:26, Vyom Tewari wrote:
> Hi everyone,
> Can you please review my changes for below bug.
>
> Bug:
>      JDK-8080402 : File Leak in 
> jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java
> Webrev:
> http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.01/
>
> This change ensure that if close() fails we throw correct io exception 
> and there is no file leak.
>
> Thanks,
> Vyom
>




More information about the core-libs-dev mailing list