RFR 8073542 : File Leak in jdk/src/java/base/unix/native/libnet/PlainDatagramSocketImpl.c

Ivan Gerasimov ivan.gerasimov at oracle.com
Wed Sep 16 13:44:46 UTC 2015


Hi Vyom!

The change looks fine, thanks.

You've used strerr() to extract the error string, so it may be good to 
coordinate your patch with the fix for JDK-8133249.
Robert (CCed) is working on it at the moment.

Sincerely yours,
Ivan

On 16.09.2015 12:08, Vyom Tewari wrote:
> Hi All,
>
> Please review my changes for below bug.
>
> Bug:
>       JDK-8073542 : File Leak in 
> jdk/src/java/base/unix/native/libnet/PlainDatagramSocketImpl.c
> Webrev:
> http://cr.openjdk.java.net/~dfuchs/vyom/8073542/webrev.00
>
> This change ensure that if "setsocketopt" fails we close the 
> corresponding fd and throw correct  exception.
>
> Thanks,
> Vyom
>




More information about the core-libs-dev mailing list