[9] Review request JDK-8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader
Alan Bateman
Alan.Bateman at oracle.com
Wed Sep 16 14:03:40 UTC 2015
On 16/09/2015 12:07, Miroslav Kos wrote:
> On 15/09/15 15:46, Alan Bateman wrote:
>>
>>
>> On 27/08/2015 19:26, Miroslav Kos wrote:
>>> Hi Alan,
>>> I added logging (at least for now) - would it work for you?
>>> updated webrev: http://cr.openjdk.java.net/~mkos/8131667/jaxws.02/
>>>
>>> If you think the exception shouldn't be ignored I suggest to solve
>>> this in separate issue (and maybe revisit all similar cases in
>>> SAAJ/JAX-*)
>> The logging looks okay now.
>>
>> A minor comment is that in fromJDKProperties then you can avoid
>> toFile() and just use Files.exists(f) if you want.
>>
>> -Alan
> Fixed here: http://cr.openjdk.java.net/~mkos/8131667/jaxws.03/
Looks okay to me.
-Alan.
More information about the core-libs-dev
mailing list