Running blessed-modifier-order on the rest of the JDK

Martin Buchholz martinrb at google.com
Thu Sep 17 16:24:36 UTC 2015


flush with success, I ran blessed-modifier-order on the entire JDK forest,
and it seems to work fine.
But we want to leave out code maintained elsewhere.  How to identify that?

Below are changes inside javadoc, which seem fine to me.

 $ hg tcommand hg diff | g '^[+-]  *\*'
-         * Access to final protected superclass member from outer class.
+         * Access to protected final superclass member from outer class.
-     * per a class in order to initialize a final static logger variable,
which is then used
+     * per a class in order to initialize a static final logger variable,
which is then used
-     * it is advised that the method is called only once per a class in
order to initialize a final static logger variable,
+     * it is advised that the method is called only once per a class in
order to initialize a static final logger variable,
-     * it is advised that the method is called only once per a class in
order to initialize a final static logger variable,
+     * it is advised that the method is called only once per a class in
order to initialize a static final logger variable,
-     *     synchronized static method of that class.
+     *     static synchronized method of that class.
- * abstract protected methods defined in this class need not synchronize
+ * protected abstract methods defined in this class need not synchronize
- *     final static ImageIcon longIcon = new ImageIcon("long.gif");
- *     final static ImageIcon shortIcon = new ImageIcon("short.gif");
+ *     static final ImageIcon longIcon = new ImageIcon("long.gif");
+ *     static final ImageIcon shortIcon = new ImageIcon("short.gif");
- * All attributes should be static private with accessors to simpify change
+ * All attributes should be private static with accessors to simpify change
- * This class holds only final static member variables that are constants
+ * This class holds only static final member variables that are constants
- * inherited static protected members differently when accessed
+ * inherited protected static members differently when accessed

# How big?
 $ hg tcommand hg st | grep -w M | wc -l
1952



More information about the core-libs-dev mailing list