RFR(S): 8136931: more fine-grained condition checking for BMH species creation

[Michael Haupt]

Hi Paul,

> Am 22.09.2015 um 19:54 schrieb Paul Sandoz <paul.sandoz at oracle.com>:
>> This is actually a change to improve error reporting for identifying the issue causing https://bugs.openjdk.java.net/browse/JDK-8131129, turning assertions into actual checks. As the issue 8131129 is intermittent and cannot be easily reproduced, the scope of additional tracing should be minimal. Enabling all assertions, even for the BoundMethodHandle class, is not helpful.
> 
> Does enabling assertions makes the problem harder to reproduce, and/or you need some more readable output?

both. I haven't been able to reproduce the problem *at all* (it does turn up every now and then, but never when I want it to), so I would like to expose it to the testing infrastructure to increase the likelihood. I also want to know what precisely went wrong; hence the detailed exception throwing.

>> This patch will be removed once the issue itself has been addressed.
> 
> +1
> 
> Suggest adding a comment to stating this is a temporary property that will be removed:
> 
>  54     static final boolean OBSERVE_BMH_SPECIES_CREATION;

Thank you; I will add this comment before pushing.

Best,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment