RFR: 8033661: readConfiguration does not cleanly reinitialize the logging system
Mandy Chung
mandy.chung at oracle.com
Wed Sep 23 21:31:35 UTC 2015
> On Sep 23, 2015, at 1:23 PM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8033661/webrev.03/
Thanks. Looks good.
Minor comments that you can fix before you push. No need to send a new webrev:
This statement occurs in a couple places:
"The function f may return null to indicate that the property k should not be added to the resulting configuration."
s/should/will
"LogManager properties are updated with the resulting value in the resulting configuration.” is in the middle of specifying the details of the mapper. Maybe moving it to before “The registered configuration listeners….”.
Mandy
More information about the core-libs-dev
mailing list