RFR (JAXP) 8135283: DOM API update: Element Traversal Specification

[huizhe wang]

On 9/25/2015 2:18 PM, Mandy Chung wrote:
>
> On 09/25/2015 12:41 PM, huizhe wang wrote:
>> Hi,
>>
>> Please review the DOM update to include the Element Traversal 
>> Specification. ElementTraversal is an interface which allows the 
>> author to restrict navigation to Element nodes.
>>
>> The implementation is the result of a merge with the upper Xerces 
>> source. The new methods implementation starts at line 1173 if you 
>> want to avoid the lot of formatting changes due to a NetBeans Source 
>> Format.
>> https://bugs.openjdk.java.net/browse/JDK-8135283
>> http://cr.openjdk.java.net/~joehw/jdk9/8135283/webrev/
>
> Thanks for doing this.

Yay, finally got around to get this done!
>
> With this application/libraries used to put xml-apis-2.11.0.jar on the 
> endorsed/ext directory or classpath no longer needs to do that because 
> org.w3c.dom.ElementTraversal was not part of the DOM API endorsed by 
> JAXP in JDK 8.
>
> I skimmed through the change that looks okay.
>
> 214                         URI _uri = new URI(uri, true);
>
> This change removed the catching of MalformedURLException that will 
> fall back to use parentBaseURI. i.e. now it won't fall back to use 
> parentBaseURI if line 214 throws MUE.  Is that intentional?

Yes. It was a performance improvement, quote:

Reduce MalformedURIExceptions thrown while
resolving xml:base. The URI class previously only accepted
absolute URIs so at least one exception was always being
thrown for relative URIs.

>
> ElementTraveral.java
>
>   52  * See also the
>
> This can use @see instead

Fixed.

Thanks,
Joe

>
> Mandy
>