RFR: 8137289: java/util/logging/DrainFindDeadlockTest.java hangs

[Chris Hegarty]

On 29 Sep 2015, at 19:15, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:

> Hi,
> 
> Please find below a fix for:
> 8137289: java/util/logging/DrainFindDeadlockTest.java hangs
> https://bugs.openjdk.java.net/browse/JDK-8137289
> 
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webrev_8137289/webrev.00/
> 
> There are in fact two failures reports under similar configuration:
> (slow machines?) - fastdebug build - -Xcomp -server -Xcomp
> 
> The first thread dump in the bug shows that the test is killed
> while the test main class is still initializing.
> The test hasn't even started yet.
> 
> The second thread dump shows the main class waiting to join
> the DeadlockChecker.
> The other threads created by the test are nowhere to be seen.
> 
> In view of theses two stacks, my analysis is that this is most
> probably an issue caused by the timeout=10 parameter on the @run
> line.
> 
> I'm proposing to remove this timeout and default to jtreg's
> timeout.

Removing the timeout is the right thing to do. It serves no purpose, other than to timeout the test if the bug ever exists, which if it does should be fixed ;-) Looks good.

-Chris.

> I have also added some additionally prints to show
> when threads created by the test terminate...
> 
> We will see if that solves the issue...
> 
> best regards,
> 
> -- daniel