RFR: JDK-8152622: tools/pack200/Pack200Props.java timed out

[Kumar Srinivasan]

Alan,

http://cr.openjdk.java.net/~ksrini/8152622/webrev.02/

I made the changes as you suggested below, I have retained 
Files.createDirectories,
here is why, changing it to createDirectory will throw 
FileAlreadyExistsException,
which means, that if the output zip/jar file exists then an exception 
handler is
required to ignore it. I don't think its worth the trouble.

Thanks

Kumar



>
>
> On 06/04/2016 14:09, Kumar Srinivasan wrote:
>>
>>>
>>> - Is Files.createDirectories needed? The walk is specified to be 
>>> depth first so you'll also visit parent directories first.
>>
>> Yes, zipfs does not allow me to create the file without creating the 
>> enclosing directory
>> first, so if I were to do this in visitFile, then presumably I would 
>> have to add a
>> check, to prevent duplicate creation going into the provider, only to 
>> find a
>> directory already exists and return, not sure if this is what you 
>> want, because
>> preVisitDirectory does this conveniently.
> I should have been clearer, I was trying to say that createDirectory 
> should be sufficient here because the walk is specified to be depth 
> first.
>
>>
>>>
>>> - I'm also curious about the REPLACE_EXISTING as I assume that isn't 
>>> needed.
>>
>> Oh! while I was developing in NB as a discrete/stand alone project, I 
>> was reusing the
>> same zip/jar output file,  will leave it as-is, no harm, right ?.
> No harm, it just caught my eye as not needed.
>
> -Alan