RFR: 8150469: unpack200 fails to compare crc correctly.

John Rose john.r.rose at oracle.com
Wed Apr 6 22:03:29 UTC 2016


Looks good, a clean fix.  The negative test should be called "testBadChecksum" or "testBrokenTrailer".

— John

On Feb 29, 2016, at 8:06 AM, Kumar Srinivasan <kumar.x.srinivasan at oracle.com> wrote:
> 
> Hello John, Alex,
> 
> Please review fix for https://bugs.openjdk.java.net/browse/JDK-8150469
> 
> The previous fix keeps the storage in the unpacker object which is
> reset, for a multi-segmented pack archive, thus the computed crc32 is lost.
> 
> Now the storage is moved into the gzip container, which persists, across
> multiple segments, I  also added the length check as specified by RFC 1952,
> as  implemented by JDK.
> 
> http://hg.openjdk.java.net/jdk9/dev/jdk/file/e4af8119eba4/src/java.base/share/classes/java/util/zip/GZIPInputStream.java#l222
> 
> The review is at:
> http://cr.openjdk.java.net/~ksrini/8150469/webrev.00/
> 
> 
> Thanks
> Kumar
> 
> 




More information about the core-libs-dev mailing list