RFR 8151198: VarHandle factory-specific exceptions

Paul Sandoz paul.sandoz at oracle.com
Fri Apr 8 16:52:57 UTC 2016


> On 8 Apr 2016, at 17:59, Martin Buchholz <martinrb at google.com> wrote:
> 
> On Fri, Apr 8, 2016 at 7:40 AM, Aleksey Shipilev
> <aleksey.shipilev at oracle.com> wrote:
>> On 04/08/2016 03:51 PM, Paul Sandoz wrote:
>>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8151198-VH-factory-exceptions/webrev/
>>> <http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8151198-VH-factory-exceptions/webrev/>
>> 
>> I agree with updates.
>> 
>> But have more comments on C/C++ @apiNote-s. Would you like to address
>> them in follow-ups? Notably, getVolatile may be also marked analogous to
>> memory_order_seq_cst, and get/setOpaque may be marked analogous to C/C++
>> "volatile"-s. And CAS/CAE memory semantics can also be spelled out in
>> terms of std::memory_order.
> 
> I agree with Aleksey.


No objections, i will follow up using https://bugs.openjdk.java.net/browse/JDK-8153875 <https://bugs.openjdk.java.net/browse/JDK-8153875>

Thanks,
Paul.



More information about the core-libs-dev mailing list