RFR 8151706: Update VarHandle implementation to use @Stable arrays

Claes Redestad claes.redestad at oracle.com
Mon Apr 11 11:00:16 UTC 2016


Looks good

/Claes

On 2016-04-11 12:55, Paul Sandoz wrote:
>> On 8 Apr 2016, at 16:11, Michael Haupt <michael.haupt at oracle.com> wrote:
>>
>> Hi Paul,
>>
>> note this is a lower-case review. Having looked at 8151705, thumbs up for this one as well - they go hand in hand and looking at one of them only doesn't feel right. :-)
>>
> Thanks. I got ‘em swapped the wrong way around. I am gonna re-base this one and push, otherwise it will be blocked waiting on the CCC of 8151705.
>
>
>> On 8 Apr 2016, at 16:23, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>>
>> On 04/08/2016 12:56 PM, Paul Sandoz wrote:
>>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8151706-VH-form-table-stable/webrev/
>>> <http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8151706-VH-form-table-stable/webrev/>
>>>
>>> Now that @Stable arrays are supported by C1 (thanks Vladimir!) we
>>> can switch from the explicit use of MemberName fields in VarForm to a
>>> @Stable MemberName[] array.
>> Yes, glad to see that abomination gone.
>>
> Indeed!
>
>
>> I've checked C1 and C2 performance against our battery of VarHandle
>> microbenchmarks, and there were no regressions. So, +1.
> Thanks,
> Paul.
>




More information about the core-libs-dev mailing list