Review request 8153912: StackFrame::getFileName and StackFrame::getLineNumber not needed
Mandy Chung
mandy.chung at oracle.com
Mon Apr 11 21:22:39 UTC 2016
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153912/webrev.00/index.html
StackFrame::getFileName and StackFrame::getLineNumber are originally proposed with the view of any stack walking code can migrate to the StackWalker API without the use of StackTraceElement.
File name and line number are useful for debugging and troubleshooting purpose. It has additional overhead to map from a method and BCI to look up the file name and line number.
StackFrame::toStackTraceElement method returns StackTraceElement that includes the file name and line number. There is no particular benefit to duplicate getFileName and getLineNumber methods in StackFrame. It is equivalently convenient to call StackFrame.toStackTraceElement().getFileName() (or getLineNumber).
This patch proposes to remove StackFrame::getFileName and StackFrame::getLineNumber methods since such information can be obtained from StackFrame.toStackTraceElement().
Mandy
More information about the core-libs-dev
mailing list