Review request 8153895 (proxy) redundant read edges to superinterfaces of proxy interfaces

Chris Hegarty chris.hegarty at oracle.com
Tue Apr 12 08:02:57 UTC 2016


Looks ok Mandy.

-Chris.

On 12 Apr 2016, at 00:45, Mandy Chung <mandy.chung at oracle.com> wrote:

> Peter spots the redundant read edges are added to dynamic module when creating a proxy class.   Proxy class does not access super interfaces of proxy interfaces.   I have verified this simple patch with all core tests and JCK api tests.
> 
> diff --git a/src/java.base/share/classes/java/lang/reflect/Proxy.java b/src/java.base/share/classes/java/lang/reflect/Proxy.java
> --- a/src/java.base/share/classes/java/lang/reflect/Proxy.java
> +++ b/src/java.base/share/classes/java/lang/reflect/Proxy.java
> @@ -804,11 +804,6 @@
>                     continue;
>                 }
>                 ensureAccess(target, c);
> -
> -                // add all superinterfaces
> -                for (Class<?> intf : c.getInterfaces()) {
> -                    deque.add(intf);
> -                }
>             }
> 
>             // set up proxy class access to types referenced in the method signature




More information about the core-libs-dev mailing list