RFR: 8153293 - Stream API: Preserve SORTED and DISTINCT characteristics for boxed() and asLongStream() operations

Stefan Zobel spliterator at gmail.com
Tue Apr 12 20:30:16 UTC 2016


Hi Tagir,

thanks! Looks fine to me now - especially the new testSortDistinct() methods.
But note: I'm only a participant, not a reviewer of any sort.

Thanks,
Stefan


2016-04-12 18:37 GMT+02:00 Tagir F. Valeev <amaembo at gmail.com>:
> Hello!
>
> Thank you, Stefan and Paul for review. Here's updated webrev:
>
> http://cr.openjdk.java.net/~tvaleev/webrev/8153293/r2/
>
> Changes:
> - all new mapToObj are private and not final
> - IntStream.asDoubleStream preserves distinct now
> - Tests fixed according to Stefan's suggestions
> - Additional tests added which test how sorted and distinct actually
>   work, as Paul suggests. Values close to Integer.MAX_VALUE and Long.MAX_VALUE
>   are tested. TreeSet<Long> and TreeSet<Double> is used to produce
>   expected result.
>
> With best regards,
> Tagir Valeev.
>



More information about the core-libs-dev mailing list