RFR:JDK-8154050:java.time.format.DateTimeFormatter can't parse localized zone-offset

Roger Riggs Roger.Riggs at Oracle.com
Wed Apr 13 15:56:30 UTC 2016


Hi Nadeesh,

The bugfix looks fine.

The TODO comment on the "GMT" raises the question (as a separate issue)
about implementing the TODO or removing the TODO comment.

I'm not sure where the localized string for "GMT" would come from but it 
might be a useful improvement
unless it was judged to a compatibility issue.

Roger



On 4/13/2016 10:19 AM, nadeesh tv wrote:
> HI all,
>
> Bug Id - https://bugs.openjdk.java.net/browse/JDK-8154050 
> <https://bugs.openjdk.java.net/browse/JDK-8154050>
>
> Issue - java.time.format.DateTimeFormatter can't parse localized 
> zone-offset
>
> Solution - Corrected the mistake in calculating parse end position  
> and removed an unnecessary null check
>
>
> webrev - http://cr.openjdk.java.net/~ntv/8154050/webrev.00/ 
> <http://cr.openjdk.java.net/%7Entv/8154050/webrev.00/>
>
> PS: TCKOffsetPrinterParser.test_print_localized() already contain some 
> test cases related to parsing and formatting. therefore did not repeat 
> in the new test cases file
> -- 
> Thanks and Regards,
> Nadeesh TV
>




More information about the core-libs-dev mailing list