RFR 9: 8086278 : java/lang/ProcessHandle/TreeTest.java failed - ProcessReaper StackOverflowException
Chris Hegarty
chris.hegarty at oracle.com
Wed Apr 13 17:12:12 UTC 2016
On 13/04/16 18:11, Roger Riggs wrote:
> Hi Chris,
>
> On 4/13/2016 12:02 PM, Chris Hegarty wrote:
>> On 13/04/16 16:42, Roger Riggs wrote:
>>> Please review an increase in the default stack size of the Process
>>> reaper thread to 48K from 32k.
>>> Some tests with various VM arguments are failing intermittently.
>>> The failures are not reproducible.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~rriggs/webrev-reaper-stack-8086278/
>>
>> Seems reasonable.
>>
>> While you are there, is there any reason why the reaper cannot
>> use the overloaded Thread constructor to suppress inheriting
>> inheritable-thread-local initial values?
> ok, done.
>
> I also moved the reading of the system property to the once only code
> instead of inside the thread factory.
> Nested lambda make it harder to see what is executed when.
Looks ok.
-Chris.
More information about the core-libs-dev
mailing list