RFR 9: 8086278 : java/lang/ProcessHandle/TreeTest.java failed - ProcessReaper StackOverflowException

[Roger Riggs]

HI Martin,

I thought if I overshot, I'd get some push back on too big stack sizes.

I'll use 128k and see.

Thanks, Roger


On 4/13/2016 4:09 PM, Martin Buchholz wrote:
> The change itself is fine.
>
> On Wed, Apr 13, 2016 at 1:08 PM, Martin Buchholz <martinrb at google.com> wrote:
>> If you're actually seeing faiures with 32k, then 48k is too
>> conservative.  I suggest 128k.
>>
>> I tried once to increase the limit to 64k, but without a failing test
>> it didn't get any support.
>>
>> The presence of native thread local variables is the biggest reason
>> for blowing the stack; no limit is actually safe!  That's a deep
>> hotspot/glibc problem.
>>
>>
>> On Wed, Apr 13, 2016 at 8:42 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>>> Please review an increase in the default stack size of the Process reaper
>>> thread to 48K from 32k.
>>> Some tests with various VM arguments are failing intermittently.
>>> The failures are not reproducible.
>>>
>>> Webrev:
>>>     http://cr.openjdk.java.net/~rriggs/webrev-reaper-stack-8086278/
>>>
>>> Issue:
>>>     https://bugs.openjdk.java.net/browse/JDK-8086278
>>>
>>> Thanks, Roger
>>>