RFR: JDK-8147460: Clean-up jrtfs implementation

Alan Bateman Alan.Bateman at oracle.com
Thu Apr 14 18:57:41 UTC 2016



On 13/04/2016 19:55, Xueming Shen wrote:
> Hi,
>
> Please hep review the cleanup changes for jrtfs implementation.
>
I'm skimmed through the changes and it looks very good.

My only concern is that we might have not enough tests for jrtfs to 
exercise it completely. I just checked the coverage it is indeed quite 
low. I'll create a bug for this.

In passing, in JrtDirectoryStream then the spec allows for read ahead 
and so the original implementation was okay to return this when closed. 
What you have is fine, just pointing out that both behaviors are allowed.

-Alan



More information about the core-libs-dev mailing list