RFR: 8154470: defines.h confused about PROGNAME and JAVA_ARGS

Martin Buchholz martinrb at google.com
Mon Apr 18 17:30:04 UTC 2016


Hi Kumar and Alan,

I'd like you to do a code review.

http://cr.openjdk.java.net/~martin/webrevs/openjdk9/PROGNAME/
https://bugs.openjdk.java.net/browse/JDK-8154470

Sorry, I got carried away hacking on the tests.  Some changes could be
split out.
Aside from fixing the logic error in defines.h,

printing out tr.status is useless, because it just invokes
Object.toString on PrintWriter

-            System.out.println(tr.status);
+            System.out.println(tr);

It's complete coincidence this extends Kumar's recent test testJLDEnvWithTool.



More information about the core-libs-dev mailing list