RFR(S): 8152667: MHs.iteratedLoop(...) throws unexpected WMTE, disallows Iterator subclasses, generates inconsistent loop result type
Michael Haupt
michael.haupt at oracle.com
Fri Apr 22 11:37:21 UTC 2016
Hi Claes,
thank you - I've applied this simple change and pushed.
Best,
Michael
> Am 22.04.2016 um 12:13 schrieb Claes Redestad <claes.redestad at oracle.com>:
>
> Hi,
>
> change looks good.
>
> There's a small pre-existing inefficiency in that initit is created unconditionally but only used if iterator == null, thus could be refactored into an if (iterator == null) ... else construct
>
> Thanks!
>
> /Claes
>
> On 2016-04-20 11:25, Michael Haupt wrote:
>> Dear all,
>>
>> please review this change.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8152667
>> Webrev: http://cr.openjdk.java.net/~mhaupt/8152667/webrev.00/
>>
>> Thanks,
>>
>> Michael
>>
>
--
<http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany
ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
<http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
More information about the core-libs-dev
mailing list