RFR (JAXP) 8154220 : Semi-colon delimited list of catalog files in System property is throwing IllegalArgumentException

[Lance Andersen]

Looks better joe

Best
Lance
> On Apr 27, 2016, at 6:45 PM, huizhe wang <huizhe.wang at oracle.com> wrote:
> 
> 
> On 4/27/2016 12:42 PM, Lance Andersen wrote:
>> Hi Joe,
>> 
>> Overall it is OK.
>> 
>> I might have considered using @Beforeclass vs a static block in the test.  Also, once you check the property, you could then set your offset and avoid the extra check and need for the isWindows boolean.  That is more of a style choice though.
> 
> Thanks Lance. Updated using @Beforeclass to set up a filepath field.
> 
> http://cr.openjdk.java.net/~joehw/jdk9/8154220/webrev/ <http://cr.openjdk.java.net/~joehw/jdk9/8154220/webrev/>
> 
>> 
>> I am OK either way,  I just try to leverage the testng annotations when I can.
> 
> Yeah, make sense.
> 
> Best,
> Joe
> 
>> 
>> Best
>> Lance
>>> On Apr 27, 2016, at 3:06 PM, huizhe wang <huizhe.wang at oracle.com <mailto:huizhe.wang at oracle.com>> wrote:
>>> 
>>> Hi,
>>> 
>>> Please review the following issue and fix:
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8154220 <https://bugs.openjdk.java.net/browse/JDK-8154220>
>>> webrev: http://cr.openjdk.java.net/~joehw/jdk9/8154220/webrev/ <http://cr.openjdk.java.net/%7Ejoehw/jdk9/8154220/webrev/>
>>> 
>>> Thanks,
>>> Joe
>>> 
>> 
>> <Mail Attachment.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering 
>> 1 Network Drive 
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> 
>> 
>> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>